Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Rarity Backgrounds compatibility with Backpack Preview #384

Merged

Conversation

AzureAaron
Copy link
Collaborator

Makes item rarity backgrounds compatible with backpack preview

The solution was to draw the background with depth testing, and to translate the z by 400f before that so it doesn't render behind the storage menu (can't believe I didn't see this one sooner)

@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Oct 23, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to make sure, is the translation by 400 needed so items in the default gui won't appear in front while drawing with depth test enabled?

@AzureAaron
Copy link
Collaborator Author

LGTM. Just to make sure, is the translation by 400 needed so items in the default gui won't appear in front while drawing with depth test enabled?

Yes, 200f wasn't enough so I did 400f instead.

@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 25, 2023
@kevinthegreat1 kevinthegreat1 merged commit 879ca0f into SkyblockerMod:master Oct 25, 2023
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Oct 25, 2023
@AzureAaron AzureAaron deleted the rarity-backgrounds-compat branch October 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants