New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the crafting UI look like the vanilla crafting table #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, some naming convensions, and needs testing.
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreen.java
Outdated
Show resolved
Hide resolved
pls remove the |
Not in the texture, however the string is hard coded. Imma change that |
I kinda agree with the fact the quick craft line is kinda bad ? In French it would have to be written as Fabrication Rapide, which obv is way too long the game show the things as-is, we should just show the same tooltip that you would when the slot is empty and hovered the game should also show the tooltip when the + button is hovered |
tooltip is already there cuz it literally just displays the items in that slot. So I'm gonna yeet the string |
it displays the glass panes ? |
I made barrier not render cuz it looked weird, but glass panes still render. They don't look too out of place EDIT: did not prevent clicking on output slot aka barrier, and base skyblocker prevents clicking on black stained glass panes |
actually preventing to click could go wrong as if you click with the same item, it does things, so not preventing the output one is fine |
hard coded, I can try and get the original tooltip |
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreenHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreenHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreenHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockCraftingTableScreenHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add config. Also this doesn't work if betterPartyFinder
is turned off. See HandledScreenProviderMixin
.
2ea2ff7
to
f0069ca
Compare
f0069ca
to
771f02b
Compare
Self explanatory ain't it?
High Res Images