Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Garden UI #682

Merged
merged 3 commits into from
May 4, 2024

Conversation

BigloBot
Copy link
Contributor

@BigloBot BigloBot commented May 4, 2024

-Fixes Regex Parsing for over 1000% Skill Level [I do suck at regex though]
image

-Fixes XP Calculation (Hypixel appears to only update the client for a single block break worth of xp every half a second)

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 4, 2024
@BigloBot BigloBot marked this pull request as draft May 4, 2024 08:05
@LifeIsAParadox LifeIsAParadox added wip This PR is a work in progress and removed reviews needed This PR needs reviews labels May 4, 2024
@BigloBot BigloBot marked this pull request as ready for review May 4, 2024 08:08
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels May 4, 2024
@BigloBot BigloBot marked this pull request as draft May 4, 2024 08:13
@LifeIsAParadox LifeIsAParadox added wip This PR is a work in progress and removed reviews needed This PR needs reviews labels May 4, 2024
@BigloBot BigloBot force-pushed the fix-regexMatcher-over-999% branch from cb73e5a to 152396d Compare May 4, 2024 08:28
@BigloBot BigloBot marked this pull request as ready for review May 4, 2024 08:32
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels May 4, 2024
@viciscat
Copy link
Collaborator

viciscat commented May 4, 2024

The Farming HUD going over 100% has been fixed already in beta so idk if that regex change is needed

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels May 4, 2024
@kevinthegreat1
Copy link
Collaborator

Fixes #637

@kevinthegreat1 kevinthegreat1 linked an issue May 4, 2024 that may be closed by this pull request
@BigloBot
Copy link
Contributor Author

BigloBot commented May 4, 2024

The Farming HUD going over 100% has been fixed already in beta so idk if that regex change is needed
Latest 1.20.6 Beta:
image

My PR
image

Co-authored-by: Kevin <92656833+kevinthegreat1@users.noreply.github.com>
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels May 4, 2024
Co-authored-by: Kevin <92656833+kevinthegreat1@users.noreply.github.com>
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels May 4, 2024
@kevinthegreat1 kevinthegreat1 added bug Something isn't working good first issue Welcome new contributors :) labels May 4, 2024
@viciscat viciscat merged commit ed04895 into SkyblockerMod:master May 4, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Welcome new contributors :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Farming XP/h counter bugged
4 participants