Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CMake rules #38

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Improve CMake rules #38

merged 1 commit into from
Jun 7, 2020

Conversation

Shatur
Copy link
Collaborator

@Shatur Shatur commented Jun 6, 2020

  • Disable building examples by default. Let me now if you not agree with it.
  • Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR. Otherwise you will have an error if you will build the project as a sub-directory of another.
  • Add an option to disable install rules. This is needed if user want to use this library as a static.

@Shatur
Improve CMake rules
055d242 
* Disable building examples by default.
* Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR.
* Add an option to disable install rules.
@Skycoder42 Skycoder42 merged commit c373d83 into Skycoder42:master Jun 7, 2020
@Shatur Shatur deleted the improve-cmake-rule branch June 7, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skycoder42 Skycoder42 Skycoder42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shatur @Skycoder42