Add new environment variable for public version of SKYGEAR_ENDPOINT #232
Labels
Comments
Steven-Chan
added a commit
to SkygearIO/skygear-server
that referenced
this issue
Nov 28, 2018
- Default value and validation are for env and json config source only. Since we used msgp for transporting through request header, which is not the config source. The input and output will be the same and the default value and validation is not applied - Allow static default by updating `NewTenantConfiguration` - Allow a degree of flexible to update dynamic default in `AfterUnmarshal` - SkygearIO/py-skygear#232 is not addressed here, since gear communicate is through public gateway now. And we may want to revisit in when we do cloud function and see if it is still valid. Refs #791.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we used
SKYGEAR_ENDPOINTas default of pubsub and skygear container endpoint in py-skygear, so I assume thatSKYGEAR_ENDPOINTshould be the skygear server endpoint in the private network. But for some cases like generating reset password link. We will want to have a public version of skygear server endpoint. So I suggest that we should have both public and private version of skygear endpoint config in py-skygear so we can use them in different case. If my assumption of "SKYGEAR_ENDPOINTshould be private" is correct, maybe we can addSKYGEAR_PUBLIC_ENDPOINT?Note: After we updated, we should also update plugins default. For example, skygear-sso callback url default, forgot_password reset password, verify url default... etc.
The text was updated successfully, but these errors were encountered: