Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other oauth api #160

Merged
merged 5 commits into from Dec 23, 2017
Merged

Other oauth api #160

merged 5 commits into from Dec 23, 2017

Conversation

carmenlau
Copy link
Contributor

After PR #157

  • login or link with access token
  • unlink provider
  • get oauth provider user profiles

connect #140
connect #141
connect #142
connect #143

@rickmak
Copy link
Member

rickmak commented Dec 21, 2017 •
edited

I got an error on /Working/skygear-SDK-iOS/Example/Swift Example/View Controllers/RecordViewController.swift:23:1: error: Class Delegate Protocol Violation: Delegate protocols should be class-only so they can be weakly referenced. (class_delegate_protocol) while I try to compile.

Code wise I cannot spot any issue.

@cheungpat cheungpat merged commit da36dfa into SkygearIO:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickmak rickmak rickmak approved these changes

@cheungpat cheungpat Awaiting requested review from cheungpat

Assignees

@cheungpat cheungpat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carmenlau @rickmak @cheungpat