This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Actually fetch assets data in query #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 13, 2017 19:40
b123400
force-pushed
the
fix-missing-asset-type
branch
from
641e2a6
to
d3a9329
Compare
ben181231
suggested changes
Feb 15, 2017
| @@ -45,6 +46,42 @@ func (c *conn) GetAsset(name string, asset *skydb.Asset) error { | |||
| return err | |||
| } | |||
|
|
|||
| func (c *conn) GetAssets(names []string) ([]skydb.Asset, error) { | |||
There was a problem hiding this comment.
Better to change GetAsset to use GetAssets to reduce code duplication.
|
ping @b123400 ? |
|
Updated |
rickmak
added a commit
to rickmak/skygear-server
that referenced
this pull request
Mar 28, 2017
cheungpat
added a commit
that referenced
this pull request
Mar 29, 2017
This is required to maintain backward compatibility with old SDK clients which may not send content type in the record JSON format when communicating with the server. refs #287
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect SkygearIO/skygear-SDK-JS#164
The original code does not query assets at all, feels like intentionally leaving some fields blank to save a query, so this PR is not really fixing bug, but adding functionality.