Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix poor IterativeGradientDescent results #181

Merged
merged 1 commit into from Mar 1, 2015
Merged

fix poor IterativeGradientDescent results #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ng4j-core/src/main/java/org/deeplearning4j/optimize/solvers/IterationGradientDescent.java
View file
Open in desktop
Expand Up @@ -46,13 +46,11 @@ public IterationGradientDescent(NeuralNetConfiguration conf, StepFunction stepFu
@Override
public boolean optimize() {
for(int i = 0; i < conf.getNumIterations(); i++) {
model.setScore();
Pair<Gradient,Double> score = gradientAndScore();
updateGradientAccordingToParams(score.getFirst(), model, batchSize());
model.update(score.getFirst());
// model.update(score.getFirst()); // this line causing very bad optimization results
for(IterationListener listener : conf.getListeners())
listener.iterationDone(model,i);

log.info("Error at iteration " + i + " was " + model.score());
}
return true;
}
Expand Down