Log to disk #35
Merged
Log to disk #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PINNER_LOG_FILE env var that specifies the file. Empty disables.
MSevey
suggested changes
Jun 21, 2022
MSevey
previously approved these changes
Jun 22, 2022
peterjan
reviewed
Jul 1, 2022
peterjan
reviewed
Jul 4, 2022
peterjan
approved these changes
Jul 4, 2022
ChrisSchinnerl
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR adds an optional env var which specifies a file on disk to which Pinner should write its logs. If the var is missing or empty, we don't write to disk.
Example for Visual Changes
Checklist
Issues Closed
Closes SKY-756