Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Add missing test coverage #156

Merged
merged 8 commits into from
Jun 23, 2021
Merged

Add missing test coverage #156

merged 8 commits into from
Jun 23, 2021

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Jun 10, 2021

Note: MySky tests will be added separately

@mrcnski
Add missing test coverage
264a2c7 
Note: MySky tests will be added separately
ro-tex
ro-tex previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@ro-tex ro-tex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some of the tests that cover skylink lengths are a bit bare (only checking empty string) but they do their job.

src/crypto.test.ts Show resolved Hide resolved
src/download.test.ts Show resolved Hide resolved
src/skydb.ts Outdated Show resolved Hide resolved
src/upload.test.ts Outdated Show resolved Hide resolved
@mrcnski mrcnski requested a review from ro-tex June 18, 2021 15:34
ro-tex
ro-tex previously approved these changes Jun 21, 2021
View reviewed changes
@mrcnski mrcnski requested a review from ro-tex June 21, 2021 22:29
@kwypchlo kwypchlo merged commit 32a2298 into master Jun 23, 2021
@kwypchlo kwypchlo deleted the increase-coverage branch June 23, 2021 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ro-tex ro-tex ro-tex approved these changes

@kwypchlo kwypchlo kwypchlo approved these changes

@peterjan peterjan Awaiting requested review from peterjan

@dghelm dghelm Awaiting requested review from dghelm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrcnski @ro-tex @kwypchlo