This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Fix mySky.getEntryLink and file.getEntryLink bug #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests added and passing in #139, where this bug was originally fixed.
peterjan
reviewed
Jun 25, 2021
kwypchlo
suggested changes
Jun 25, 2021
There was a problem hiding this comment.
will approve after https://github.com/SkynetLabs/skynet-js/blob/master/src/mysky/index.ts#L308 is fixed too
mrcnski
changed the title
kwypchlo
approved these changes
Jun 25, 2021
peterjan
reviewed
Jun 28, 2021
| const client = new SkynetClient(portalUrl); | ||
|
|
||
| describe("getEntryLink", () => { | ||
| it("Should get the entry link for a user ID and path", async () => { |
There was a problem hiding this comment.
It was moved as-is to integration.test.ts. We should probably split that file up one day, though.
peterjan
approved these changes
Jun 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added and passing in #139,
where this bug was originally fixed.