-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIAppearance implementation #118
Conversation
Brillaint work @mwfire. Thanks for the PR, I'm gonna have a look at it later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add an entry to CHANGELOG.md
under the master
section crediting yourself and referencing this PR?
/// The value of the title disappearing duration | ||
open var titleFadeOutDuration:TimeInterval = 0.3 | ||
dynamic open var titleFadeOutDuration:TimeInterval = 0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done any UIAppearance customization with Swif, but isn't there a need for a marking such as UI_APPEARANCE_SELECTOR
in Objective-C to inform the run time that this can be customized via UIAppearance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotating properties withdynamic
is sufficient to support UIAppearance in Obj-C as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat :)
Sry, my version of changelog was not up-to-date. :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also replaces the top comment in all new source files with this https://github.com/Skyscanner/SkyFloatingLabelTextField/blob/master/Sources/SkyFloatingLabelTextField.swift#L1-L7
Thanks @mwfire I'm gonna close this PR and perform the merge outside of git so I can clean up some of the commits and resolve the conflicts |
Hey guys,
With this PR I have added the ability to use UIAppearance for global style settings. I recommend to create a new base branch to merge and review this PR, I might have missed something. I added an example and tests. However, I have neither updated the readme nor have I bumped the version.
Let's see if that's of any use for you ;)
Cheers
Martin