Take clearButton into account in editingRect #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogren
approved these changes
Jun 13, 2017
k0nserv
commented
Jun 13, 2017
| x: superRect.origin.x, | ||
| y: titleHeight, | ||
| width: superRect.size.width, | ||
| height: bounds.size.height - titleHeight - selectedLineHeight |
There was a problem hiding this comment.
Suppose this should be superRect.size.height instead of bounds.size.height
|
Yeah I suppose we should take all values from superRect? |
|
Yes I think that would be better :) |
k0nserv
force-pushed
the
editing-react-clear
branch
from
22007c6
to
2be13a6
Compare
|
Done |
k0nserv
force-pushed
the
editing-react-clear
branch
from
2be13a6
to
61d9a3b
Compare
|
@bogren Does this look good now? |
bogren
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147