Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full support for the swift package manager #296

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

acecilia
Copy link
Contributor

@acecilia acecilia commented Sep 1, 2019

In this PR:

  • Added full support for the swift package manager.
  • Had to change the tests to not use image literal, as SPM does not support resources.

For completing this PR, the naming scheme of the tags has to be changed: seems like SPM does not support a tag like v3.7.0: the v prefix has to be removed. See a related discussion in groue/GRDB.swift#72 (comment). This issue is also mentioned in #288 (comment).

@k0nserv
Copy link
Contributor

k0nserv commented Dec 5, 2019

Thanks @acecilia

@k0nserv k0nserv merged commit 4010938 into Skyscanner:master Dec 5, 2019
@k0nserv
Copy link
Contributor

k0nserv commented Dec 5, 2019

I've pushed new copies for all previous tags without the vsuffix

@k0nserv
Copy link
Contributor

k0nserv commented Dec 5, 2019

Future releases will not use the v suffix

@k0nserv
Copy link
Contributor

k0nserv commented Dec 5, 2019

Released in 3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants