Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary push artifacts to Docker Hub #35

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Temporary push artifacts to Docker Hub #35

merged 1 commit into from
Mar 3, 2021

Conversation

maruina
Copy link
Contributor

@maruina maruina commented Mar 2, 2021 •
edited

Skyscanner doesn't have a public repository for Docker images when users can pull unauthenticated.

This is blocking #34 as we can't test the Helm chart since we can't pull the docker image.

While we decide where to officially store our open source images, this PR push the docker image to my personal docker hub account. This was agreed internally as it's the fastest way to move forward with this ticket.

I'll raise a separate issue to point this to the official repository once we have one.

@maruina maruina mentioned this pull request Mar 2, 2021
Closed
sledigabel
sledigabel approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@sledigabel sledigabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, temporarily pushing the docker images to matteo's dockerhub

@maruina maruina merged commit f6442f9 into main Mar 3, 2021
@maruina maruina deleted the temp-push-to-dockerhub branch March 3, 2021 09:07
@maruina
Copy link
Contributor Author

maruina commented Mar 3, 2021 

❯ docker pull maruina/argocd-progressive-rollout:main
main: Pulling from maruina/argocd-progressive-rollout
9e4425256ce4: Pull complete
f20358178123: Pull complete
Digest: sha256:c7987cb5d0e903375f1321dd7d80d01e854ba36d44b995507333e466cefb3e3d
Status: Downloaded newer image for maruina/argocd-progressive-rollout:main
docker.io/maruina/argocd-progressive-rollout:main

maruina added a commit that referenced this pull request Mar 3, 2021
@maruina
Temporary push artifacts to Docker Hub (#35)
e508794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledigabel sledigabel sledigabel approved these changes

@nebojsa-prodana nebojsa-prodana Awaiting requested review from nebojsa-prodana

@logan-porelle logan-porelle Awaiting requested review from logan-porelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maruina @sledigabel