DON-384: Adjust the TextField of the Place Selector GC (#1931)

* DON-384: Adjust the TextField of the Place Selector GC [change default icon, update placeholder colour, hide a close button if it's empty] * Record snapshots * Fix hiding logic * Record snapshots * Updated snapshots * Fix icon in BPKAppSearchModalTests --------- Co-authored-by: Yura Reutskiy <yurareutskiy@skyscanner.net> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Skyscanner · Apr 5, 2024 · c40ae7a · c40ae7a
1 parent 1ebfb99
commit c40ae7a
Show file tree

Hide file tree

Showing 16 changed files with 8 additions and 1 deletion.
diff --git a/Backpack-SwiftUI/SearchInputSummary/Classes/BPKSearchInputSummary.swift b/Backpack-SwiftUI/SearchInputSummary/Classes/BPKSearchInputSummary.swift
@@ -58,7 +58,7 @@ public struct BPKSearchInputSummary: View {
         HStack(spacing: .md) {
             prefixView
                 .accessibilityHidden(true)
-            TextField(placeholder, text: $text)
+            TextField(placeholder, text: $text, prompt: placeholderView)
                 .font(style: .bodyDefault)
                 .foregroundColor(state.textColor)
                 .disabled(state.isDisabled)
@@ -82,6 +82,7 @@ public struct BPKSearchInputSummary: View {
                     BPKIconView(icon.icon)
                         .foregroundColor(icon.color)
                 }
+                .opacity(text.isEmpty ? 0.0 : 1.0)
                 .accessibilityElement(children: .ignore)
                 .accessibilityLabel(accessibilityLabel)
                 .accessibilityAddTraits(.isButton)
@@ -93,6 +94,12 @@ public struct BPKSearchInputSummary: View {
         }
     }
 
+    @ViewBuilder
+    private var placeholderView: Text {
+        Text(placeholder)
+            .foregroundColor(Color(BPKColor.textSecondaryColor.value))
+    }
+
     @ViewBuilder
     private var prefixView: some View {
         switch inputPrefix {

diff --git a/...SearchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.dark-mode.png b/...SearchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.dark-mode.png
diff --git a/...earchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.light-mode.png b/...earchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.light-mode.png
diff --git a/...ts/AppSearchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.rtl.png b/...ts/AppSearchModal/__Snapshots__/BPKAppSearchModalTests/test_withContent.rtl.png
diff --git a/...napshots__/BPKAppSearchModalTests/test_withContentInputStateClear.dark-mode.png b/...napshots__/BPKAppSearchModalTests/test_withContentInputStateClear.dark-mode.png
diff --git a/...apshots__/BPKAppSearchModalTests/test_withContentInputStateClear.light-mode.png b/...apshots__/BPKAppSearchModalTests/test_withContentInputStateClear.light-mode.png
diff --git a/...al/__Snapshots__/BPKAppSearchModalTests/test_withContentInputStateClear.rtl.png b/...al/__Snapshots__/BPKAppSearchModalTests/test_withContentInputStateClear.rtl.png
diff --git a/...s__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.dark-mode.png b/...s__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.dark-mode.png
diff --git a/...__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.light-mode.png b/...__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.light-mode.png
diff --git a/...apshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.rtl.png b/...apshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsCustomText.rtl.png
diff --git a/...apshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.dark-mode.png b/...apshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.dark-mode.png
diff --git a/...pshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.light-mode.png b/...pshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.light-mode.png
diff --git a/...l/__Snapshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.rtl.png b/...l/__Snapshots__/BPKAppSearchModalTests/test_withContentWhenPrefixIsIcon.rtl.png
diff --git a/...SearchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.dark-mode.png b/...SearchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.dark-mode.png
diff --git a/...earchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.light-mode.png b/...earchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.light-mode.png
diff --git a/...ts/AppSearchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.rtl.png b/...ts/AppSearchModal/__Snapshots__/BPKAppSearchModalTests/test_withLoading.rtl.png