Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button to use Label1 #1900

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Update Button to use Label1 #1900

merged 4 commits into from
Mar 15, 2024

Conversation

gert-janvercauteren
Copy link
Contributor

BPKButton

All buttons should use label1 regardless of size.

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@gert-janvercauteren gert-janvercauteren added the patch Patch production bug label Mar 15, 2024
Copy link
Contributor

Snapshots were updated. Please verify the changes match the expected layout.

' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContent.rtl.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.light-mode.png'%0A' M Backpack-SwiftUI/Tests/AppSearchModal/Snapshots/BPKAppSearchModalTests/test_withContentInputStateClear.rtl.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader.light-mode.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader.rtl.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader_titleAndAction.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader_titleAndAction.light-mode.png'%0A' M Backpack-SwiftUI/Tests/BottomSheet/Snapshots/BPKBottomSheetTests/test_bottomSheetHeader_titleAndAction.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testDestructiveButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testDestructiveButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testDestructiveButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testFeaturedButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testFeaturedButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testFeaturedButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkOnDarkButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkOnDarkButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testLinkOnDarkButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnDarkButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnDarkButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnDarkButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnLightButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnLightButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testPrimaryOnLightButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryOnDarkButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryOnDarkButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/Button/Snapshots/BPKButtonTests/testSecondaryOnDarkButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessory.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessory.light-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessory.rtl.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessoryAndSectionHeaderButton.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessoryAndSectionHeaderButton.light-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithExpandAccessoryAndSectionHeaderButton.rtl.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithFooterButtonAccessory.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithFooterButtonAccessory.light-mode.png'%0A' M Backpack-SwiftUI/Tests/CardList/Snapshots/BPKCardListViewTests/testCardListStackWithFooterButtonAccessory.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_default.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_default.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_default.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_surfaceContrast.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_surfaceContrast.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_surfaceContrast.rtl.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_transparent.dark-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_transparent.light-mode.png'%0A' M Backpack-SwiftUI/Tests/NavBar/Snapshots/BPKNavigationViewTests/test_transparent.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultDestructive.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultDestructive.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultDestructive.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultFeatured.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultFeatured.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultFeatured.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLink.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLink.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLink.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLinkOnDark.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLinkOnDark.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultLinkOnDark.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimary.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimary.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimary.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnDark.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnDark.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnDark.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnLight.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnLight.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultPrimaryOnLight.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondary.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondary.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondary.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondaryOnDark.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondaryOnDark.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKButtonSnapshotTests/testDefaultSecondaryOnDark.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKCalendarSnapshotTest/testCalendarWithWholeMonthButton.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKCalendarSnapshotTest/testCalendarWithWholeMonthButton.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKCalendarSnapshotTest/testCalendarWithWholeMonthButton.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndFlareViewAndSmallButtons.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndFlareViewAndSmallButtons.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndFlareViewAndSmallButtons.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndTallFlareViewAndButtons.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndTallFlareViewAndButtons.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKDialogViewSnapshotTest/testDialogViewWithLargeCornerStyleAndTallFlareViewAndButtons.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButton.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButton.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButton.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButtonForiPad.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButtonForiPad.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextAndButtonForiPad.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButton.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButton.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButton.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButtonForiPad.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButtonForiPad.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithLongTextIconAndButtonForiPad.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButton.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButton.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButton.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButtonForiPad.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButtonForiPad.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextAndButtonForiPad.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButton.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButton.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButton.rtl.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButtonForiPad.dark-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButtonForiPad.light-mode.png'%0A' M Backpack/Tests/SnapshotTests/Snapshots/BPKFloatingNotificationSnapshotTests/testViewSnapshotWithTextIconAndButtonForiPad.rtl.png'

@gert-janvercauteren gert-janvercauteren added patch Patch production bug and removed patch Patch production bug labels Mar 15, 2024
Copy link
Contributor

@frugoman frugoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! good that we have the snapshot generation on ci now!!

@frugoman frugoman merged commit b639882 into main Mar 15, 2024
15 checks passed
@frugoman frugoman deleted the ralp/nojira_button_update branch March 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants