New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move content shape to HSTack to allow custom button to be tappable #1920

Merged

gert-janvercauteren merged 1 commit into main from acc/ACC-454-fix_tappable_area

Mar 27, 2024

Contributor

gert-janvercauteren commented Mar 27, 2024

App search modal

Change the contentShape modifier to apply to the button content, this way the entire button is tappable and not just the text content

Check this if you have read and followed the contributing guidelines

Remember to include the following changes:

README.md
Tests
Screenshotting code
Adding a component? Remember to expose it in the main Backpack.h header file

If you are curious about how we review, please read through the code review guidelines


          fix: Move content shape to HSTack to allow custom button to be tappable

9e2c4a6

gert-janvercauteren self-assigned this

gert-janvercauteren added patch Accessibility labels

gert-janvercauteren enabled auto-merge (squash)

March 27, 2024 10:26

frugoman approved these changes

View reviewed changes

gert-janvercauteren merged commit 29e07ca into main

16 checks passed

gert-janvercauteren deleted the acc/ACC-454-fix_tappable_area branch

March 27, 2024 10:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment