-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON-384: Update SearchField sizes and accessibility for the Place Selector GC #1930
DON-384: Update SearchField sizes and accessibility for the Place Selector GC #1930
Conversation
…and accessibility]
Snapshots were updated. Please verify the changes match the expected layout.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! thanks for this change
Update the size of the search field. Make a height minimum of 48pt (can be increased in case of large font type). Horizontal padding should be 16pt.
Also accessibility improved to make a close button available to tap and a search field is clearly pronounced as a search field.
Remember to include the following changes:
README.md
Backpack.h
header fileIf you are curious about how we review, please read through the code review guidelines