Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARGG-777]: Initial fixes to make it at least compile #173

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

xalechez
Copy link

@xalechez xalechez commented Nov 6, 2023

Changes to make react-scripts start-ssr work

  • Added .cjs to supported file extensions (otherwise they were put to "media" and not bundled)
  • Removed fallbacks to node features for client-side config to not inflate bundle size (we must discourage consumers to use node features in browser)
  • Changed entry point for SSR build
  • Aligned backpack-addons to Webpack 5 schema
  • Removed typescript formatter import as it was removed from original library
  • Added debug mode for verbose output both for Webpack and Webpack dev server
  • Replaced hash with contenthash as per Webpack 5 recommendations
  • Fixed errors in console after run in a test application

@xalechez xalechez force-pushed the ARGG-777_fixes_before_first_run branch from c4ba26c to a8d786a Compare November 6, 2023 11:47
@xalechez xalechez marked this pull request as draft November 6, 2023 11:49
@xalechez xalechez marked this pull request as ready for review November 6, 2023 16:02
packages/react-scripts/config/webpack.config.ssr.js Outdated Show resolved Hide resolved
packages/react-scripts/scripts/start.js Outdated Show resolved Hide resolved
packages/react-scripts/scripts/start.js Outdated Show resolved Hide resolved
@xalechez xalechez merged commit 8b8a589 into fork_cra5 Nov 7, 2023
2 checks passed
@xalechez xalechez deleted the ARGG-777_fixes_before_first_run branch November 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants