Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOOM-1283 BpkFieldset Class 2 Overrides #3326

Merged
merged 3 commits into from
Apr 1, 2024
Merged

LOOM-1283 BpkFieldset Class 2 Overrides #3326

merged 3 commits into from
Apr 1, 2024

Conversation

jronald01
Copy link
Contributor

@jronald01 jronald01 commented Mar 29, 2024 •
edited

Moved the styling from <BpkLabel> into a parent wrapper and updated snapshots.

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@jronald01 jronald01 added the minor Non breaking change label Mar 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 4c1073d

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3326 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3326 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3326 to see this build running in a browser.

@jronald01 jronald01 merged commit da393e4 into main Apr 1, 2024
9 checks passed
@jronald01 jronald01 deleted the loom-1283_bpk-fieldset branch April 1, 2024 14:26
@jronald01 jronald01 changed the title LOOM-1283 BpfFieldset Class 2 Overrides LOOM-1283 BpkFieldset Class 2 Overrides Apr 9, 2024
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@jronald01 @jimronald @Kathy0208
LOOM-1283 BpfFieldset Class 2 Overrides (#3326)
edf9d1c 
* LOOM-1283 BpfFieldset

* Check add to wrapper

* snapshots updated

---------

Co-authored-by: James Ronald <james.ronald@skyscanner.net>
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@jronald01 @jimronald @Kathy0208
LOOM-1283 BpfFieldset Class 2 Overrides (#3326)
4b44b48 
* LOOM-1283 BpfFieldset

* Check add to wrapper

* snapshots updated

---------

Co-authored-by: James Ronald <james.ronald@skyscanner.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mungodewar mungodewar mungodewar approved these changes

Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jronald01 @mungodewar @jimronald