Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOOM-1313][BpkSectionHeader] Class2 Fixes #3380

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[LOOM-1313][BpkSectionHeader] Class2 Fixes #3380

merged 3 commits into from
Apr 23, 2024

Conversation

metalix2
Copy link
Contributor

@metalix2 metalix2 commented Apr 22, 2024 •
edited

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@metalix2 metalix2 added the patch Patch production bug label Apr 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against aad172c

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3380 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3380 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3380 to see this build running in a browser.

@metalix2 metalix2 changed the title [LOOM-1313][BpkSectionHeader] trial with spans [LOOM-1313][BpkSectionHeader] Class2 Fixes Apr 23, 2024
@metalix2 metalix2 merged commit af5e312 into main Apr 23, 2024
9 checks passed
@metalix2 metalix2 deleted the LOOM-1313 branch April 23, 2024 13:23
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@metalix2 @Kathy0208
[LOOM-1313][BpkSectionHeader] Class2 Fixes (#3380)
b6ae518 
* trial with spans

* set textStyle

* set as h2 tag

---------

Co-authored-by: metalix2 <matthewr@skyscanner.net>
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@metalix2 @Kathy0208
[LOOM-1313][BpkSectionHeader] Class2 Fixes (#3380)
8a23b05 
* trial with spans

* set textStyle

* set as h2 tag

---------

Co-authored-by: metalix2 <matthewr@skyscanner.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sybsw Sybsw Sybsw approved these changes

Assignees
No one assigned
Labels
patch Patch production bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@metalix2 @Sybsw