Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-7842][BpkMap] Add scaleControl prop for BpkMap component #3384

Merged
merged 3 commits into from
Apr 25, 2024
Merged

[BD-7842][BpkMap] Add scaleControl prop for BpkMap component #3384

merged 3 commits into from
Apr 25, 2024

Conversation

KathyWang0208
Copy link
Contributor

@KathyWang0208 KathyWang0208 commented Apr 24, 2024 •
edited

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@KathyWang0208 KathyWang0208 changed the title Add scaleControl prop for BpkMap component [BD-7842][BpkMap] Add scaleControl prop for BpkMap component Apr 24, 2024
@KathyWang0208 KathyWang0208 added the minor Non breaking change label Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 1dc496e

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3384 to see this build running in a browser.

LuoTuxiu
LuoTuxiu approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@LuoTuxiu LuoTuxiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3384 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3384 to see this build running in a browser.

@olliecurtis olliecurtis merged commit 55ee2d8 into main Apr 25, 2024
9 checks passed
@olliecurtis olliecurtis deleted the BD-7842-support-scale branch April 25, 2024 08:17
KathyWang0208 added a commit that referenced this pull request May 27, 2024
@KathyWang0208 @Kathy0208
[BD-7842][BpkMap] Add scaleControl prop for BpkMap component (#3384)
26ae588 
* Add scaleControl prop for BpkMap component

* change scaleControl as a feature for map

* Revert the changs for REDAME

---------

Co-authored-by: Kathy Wang <kathy.wang@skyscanner.net>
KathyWang0208 added a commit that referenced this pull request May 27, 2024
@KathyWang0208 @Kathy0208
[BD-7842][BpkMap] Add scaleControl prop for BpkMap component (#3384)
9e5ea14 
* Add scaleControl prop for BpkMap component

* change scaleControl as a feature for map

* Revert the changs for REDAME

---------

Co-authored-by: Kathy Wang <kathy.wang@skyscanner.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliecurtis olliecurtis olliecurtis approved these changes

@LuoTuxiu LuoTuxiu LuoTuxiu approved these changes

Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KathyWang0208 @olliecurtis @LuoTuxiu @Kathy0208