Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOOM-1315 BpkSpinner animation fix #3394

Merged
merged 3 commits into from
Apr 30, 2024
Merged

LOOM-1315 BpkSpinner animation fix #3394

merged 3 commits into from
Apr 30, 2024

Conversation

Sybsw
Copy link
Contributor

@Sybsw Sybsw commented Apr 29, 2024 •
edited

Fix for #3360

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@Sybsw Sybsw changed the title LOOM-1315 Fix changed spans to div to preserve animation LOOM-1315 BpkSpinner Fix changed spans to div to preserve animation Apr 29, 2024
@Sybsw Sybsw added the patch Patch production bug label Apr 29, 2024
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3394 to see this build running in a browser.

@Sybsw Sybsw changed the title LOOM-1315 BpkSpinner Fix changed spans to div to preserve animation LOOM-1315 BpkSpinner animation fix Apr 29, 2024
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3394 to see this build running in a browser.

@Sybsw Sybsw marked this pull request as ready for review April 29, 2024 15:50
@mungodewar mungodewar merged commit f60a278 into main Apr 30, 2024
9 checks passed
@mungodewar mungodewar deleted the LOOM-1315_2 branch April 30, 2024 08:16
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@Sybsw @Kathy0208
LOOM-1315 BpkSpinner animation fix (#3394)
0090a04 
* LOOM-1315 Fix changed spans to div to preserve animation

* switched back to spans and added display: block
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@Sybsw @Kathy0208
LOOM-1315 BpkSpinner animation fix (#3394)
ebbc761 
* LOOM-1315 Fix changed spans to div to preserve animation

* switched back to spans and added display: block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mungodewar mungodewar mungodewar approved these changes

Assignees
No one assigned
Labels
patch Patch production bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sybsw @mungodewar