[LOOM-1295][BpkClearButton] Remove the BpkClearButton integrate directly with the BpkInput #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalix2
commented
May 1, 2024
Comment on lines
+189
to
+209
| // remove any default button styling | ||
| padding: 0; | ||
| border: 0; | ||
| background-color: transparent; | ||
| color: tokens.$bpk-text-secondary-day; | ||
| cursor: pointer; | ||
| appearance: none; // hidden by default | ||
|
|
||
| @include bpk-rtl { | ||
| right: inherit; | ||
| left: bpk-spacing-md(); | ||
| } | ||
|
|
||
| @include utils.bpk-hover { | ||
| color: tokens.$bpk-text-primary-day; | ||
| } | ||
|
|
||
| &:active { | ||
| color: tokens.$bpk-text-primary-day; | ||
| } | ||
|
|
There was a problem hiding this comment.
Lifted from BpkClearButton.module.scss
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
|
Visit https://backpack.github.io/storybook-prs/3403 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3403 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3403 to see this build running in a browser. |
metalix2
changed the title
KathyWang0208
pushed a commit
that referenced
this pull request
May 27, 2024
…tly with the BpkInput (#3403) * Update the BpkCloseButton for Class2 fixes * add snapshots * remove the ClearButton combine with BpkInput --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
KathyWang0208
pushed a commit
that referenced
this pull request
May 27, 2024
…tly with the BpkInput (#3403) * Update the BpkCloseButton for Class2 fixes * add snapshots * remove the ClearButton combine with BpkInput --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md.d.ts) files updated