Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOOM-1310][BpkRating]: remove className usage on BpkText & migrate to TS #3432

Merged
merged 3 commits into from
May 13, 2024
Merged

[LOOM-1310][BpkRating]: remove className usage on BpkText & migrate to TS #3432

merged 3 commits into from
May 13, 2024

Conversation

mungodewar
Copy link
Contributor

@mungodewar mungodewar commented May 10, 2024 •
edited

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3432 to see this build running in a browser.

@mungodewar mungodewar added the minor Non breaking change label May 10, 2024
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3432 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 6d130c1

@mungodewar mungodewar marked this pull request as ready for review May 10, 2024 15:44
@mungodewar mungodewar changed the title BpkRating to TS and remove className usage on BpkText [LOOM-1310][BpkRating]: remove className usage on BpkText & migrate to TS May 10, 2024
@mungodewar mungodewar merged commit b5d5601 into main May 13, 2024
9 checks passed
@mungodewar mungodewar deleted the loom-1310 branch May 13, 2024 08:16
FireRedNinja pushed a commit that referenced this pull request May 22, 2024
@mungodewar @FireRedNinja
[LOOM-1310][BpkRating]: remove className usage on BpkText & migrate t…
87fe791 
…o TS (#3432)

* BpkRating to TS and remove className usage on BpkText

* fixup styling

* remove old snap
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@mungodewar @Kathy0208
[LOOM-1310][BpkRating]: remove className usage on BpkText & migrate t…
6a89387 
…o TS (#3432)

* BpkRating to TS and remove className usage on BpkText

* fixup styling

* remove old snap
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
@mungodewar @Kathy0208
[LOOM-1310][BpkRating]: remove className usage on BpkText & migrate t…
b020538 
…o TS (#3432)

* BpkRating to TS and remove className usage on BpkText

* fixup styling

* remove old snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anambl anambl anambl approved these changes

Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mungodewar @anambl