Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoJira][BpkSpinner] Type SpinnerType fixes #3434

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

metalix2
Copy link
Contributor

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@metalix2 metalix2 added the patch Patch production bug label May 13, 2024
@metalix2 metalix2 changed the title Type SpinnerTypes fixes [NoJira]Type SpinnerTypes fixes May 13, 2024
@metalix2 metalix2 changed the title [NoJira]Type SpinnerTypes fixes [NoJira][BpkSpinner] Type SpinnerType fixes May 13, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3434 to see this build running in a browser.

Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against ba69e48

Copy link
Contributor

@mungodewar mungodewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metalix2 metalix2 merged commit 8eb7250 into main May 13, 2024
10 checks passed
@metalix2 metalix2 deleted the nojira-spinner-fix branch May 13, 2024 10:14
FireRedNinja pushed a commit that referenced this pull request May 22, 2024
Co-authored-by: Mungo Dewar <mungodewar@skyscanner.net>
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
Co-authored-by: Mungo Dewar <mungodewar@skyscanner.net>
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
Co-authored-by: Mungo Dewar <mungodewar@skyscanner.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants