Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .readthedocs.yaml #275

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Update .readthedocs.yaml #275

merged 2 commits into from
Mar 4, 2024

Conversation

jsoucheiron
Copy link
Member

@jsoucheiron jsoucheiron commented Feb 26, 2024 •
edited
Loading

Use python 3.9

w0rmr1d3r
w0rmr1d3r previously approved these changes Feb 29, 2024
View reviewed changes
@w0rmr1d3r
Copy link
Member

We are testing under 3.9, should we have that mismatch of versions, being the tests for docs in 3.9 and the publishing under 3.8?

Ref. https://github.com/Skyscanner/cfripper/blob/master/.github/workflows/test-docs.yml#L17

@jsoucheiron jsoucheiron mentioned this pull request Feb 29, 2024
Closed
@jsoucheiron
Copy link
Member Author

Good point, let's go with 3.9 everywhere

@w0rmr1d3r w0rmr1d3r linked an issue Mar 2, 2024 that may be closed by this pull request
ReadTheDocs link broken #276
Closed
@w0rmr1d3r w0rmr1d3r merged commit d8fd34e into master Mar 4, 2024
8 checks passed
@w0rmr1d3r w0rmr1d3r deleted the jsoucheiron-patch-1 branch March 4, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignaciobolonio ignaciobolonio ignaciobolonio approved these changes

@w0rmr1d3r w0rmr1d3r w0rmr1d3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadTheDocs link broken
3 participants
@jsoucheiron @w0rmr1d3r @ignaciobolonio