Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e testing as a github workflow #69

Merged
merged 11 commits into from
May 27, 2022
Merged

Add e2e testing as a github workflow #69

merged 11 commits into from
May 27, 2022

Conversation

Smirl
Copy link
Contributor

@Smirl Smirl commented May 26, 2022 •
edited by maruina

Summary

  • allow a --local-aws-endpoint flag for testing
  • use https://github.com/nsmithuk/local-kms as fake aws KMS endpoint
  • create github-actions workflow with simple test of a KMSKey, KMSIssuer, and Certificate.
  • ensure the KMS key is created
  • ensure the certificate is signed using the KMSIssuer

@maruina maruina marked this pull request as ready for review May 27, 2022 10:51
@maruina maruina requested a review from a team as a code owner May 27, 2022 10:51
Smirl
Smirl commented May 27, 2022
View reviewed changes
Copy link
Contributor Author

@Smirl Smirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions @maruina Lgtm but I can't approve my own PR.

@Smirl Smirl merged commit d11875c into main May 27, 2022
@Smirl Smirl deleted the e2e-tests branch May 27, 2022 17:18
@maruina maruina mentioned this pull request May 30, 2022
Closed
@maruina maruina added the enhancement New feature or request label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maruina maruina maruina approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Smirl @maruina