Disabling all arguments after foreach #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #50. Uses `DisableFlagParsing` as per the documentation to disable the subsequent flag parsing in the command and leaving it as arguments to the shell command. Added `TraverseChildren` to rootCmd to allow -v and -h to be parsed. https://pkg.go.dev/github.com/spf13/cobra#Command Tested on Mac OS. I'm unable to write tests as we're not testing the flag parsing at the moment.
|
|
DiogoMCampos
approved these changes
Jun 15, 2021
rnorth
approved these changes
Jun 16, 2021
|
I'm gonna hold off the merge for now, I'd really to figure out how docker did it and make sure we can come back and implement flags for the |
|
@sledigabel do you want to discuss this further? |
|
About to merge this; we'll get particular arguments for |
sledigabel
added a commit
that referenced
this pull request
Oct 7, 2022
the `--` were needed for any command including parameters prior to #51. After #51, the `--` are no longer needed a cobra isn't trying to parse the full command. It's also failing the run now if the `--` are included since they are interpreted as part of the command. This commit fixes the documentation associated with `foreach`.
sledigabel
added a commit
that referenced
this pull request
Oct 12, 2022
the `--` were needed for any command including parameters prior to #51. After #51, the `--` are no longer needed a cobra isn't trying to parse the full command. It's also failing the run now if the `--` are included since they are interpreted as part of the command. This commit fixes the documentation associated with `foreach`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50.
Uses
DisableFlagParsingas per the documentation to disable thesubsequent flag parsing in the command and leaving it as arguments to
the shell command.
Added
TraverseChildrento rootCmd to allow -v and -h to be parsed.https://pkg.go.dev/github.com/spf13/cobra#Command
Tested on Mac OS.
I'm unable to write tests as we're not testing the flag parsing at the
moment.