Update task generation prompt #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 7a59079e9fc6e76aabc149d1170ad77432e24034 | |--------|--------| ### Summary: This PR updates the task generation template to conditionally require `navigation_goal` and `data_extraction_goal`, enhancing task clarity and directive for the AI agent. **Key points**: - Updated `skyvern/forge/prompts/skyvern/generate-task.j2` - Made `navigation_goal` and `data_extraction_goal` conditionally required based on new reasoning fields - Removed redundant instruction about goal requirements ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Incremental review on c73f830 in 2 minutes and 14 seconds
More details
- Looked at
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_f0mMSQNKHj8JzNCH
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| is_data_extraction_goal_required: bool. This is a required field. Based on data_extraction_goal_reasoning, whether the data extraction goal is required to achieve the goal. | ||
| data_extraction_goal: str. This is an optional field. The value should be a string that we can use as an input to a Large Language Modal. It needs to tell the agent the goal in terms of extracting data. It needs to be a single goal. | ||
| navigation_payload: json. This is an optional field. The value should be JSON. Use this field if there is any information for the agent to be able to complete the task such as values that can help fill a form, parameters for queries and so on. | ||
| extracted_information_schema: json. This is an optional field. The exact schema of the data to be extracted. This field should be provided if there is a data_extraction_goal. This should be a JSON object that defines the schema of the data to be extracted. | ||
|
|
||
| At least one of navigation goal or data extraction goal should be provided. The agent can't proceed without any goals. |
There was a problem hiding this comment.
The statement 'At least one of navigation goal or data extraction goal should be provided' might be contradictory with the new fields is_navigation_goal_required and is_data_extraction_goal_required. If both are set to false based on the reasoning fields, this line could be misleading. Consider revising or removing this line to align with the new conditional requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updated task generation template to conditionally require
navigation_goalanddata_extraction_goalbased on new reasoning fields inskyvern/forge/prompts/skyvern/generate-task.j2.Key points:
skyvern/forge/prompts/skyvern/generate-task.j2navigation_goal_reasoningandis_navigation_goal_requiredfieldsdata_extraction_goal_reasoningandis_data_extraction_goal_requiredfieldsnavigation_goalanddata_extraction_goalconditionally required based on the new reasoning fieldsGenerated with ❤️ by ellipsis.dev