Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record max_steps_per_run override in tasks table as well #622

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jul 18, 2024

🚀 This description was created by Ellipsis for commit 5b5454c

Summary:

Added functionality to update the max_steps_per_run field in the tasks table when overridden during task execution, including updates to TaskResponse class.

Key points:

  • File Modified: skyvern/forge/agent.py
    • Function Modified: execute_step
      • Added logic to update max_steps_per_run in the tasks table if overridden during task execution.
  • File Modified: skyvern/forge/sdk/db/client.py
    • Function Modified: update_task
      • Added max_steps_per_run as an optional parameter to update the tasks table.
  • File Modified: skyvern/forge/sdk/schemas/tasks.py
    • Class Modified: TaskResponse
      • Added max_steps_per_run field.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 941c9b8 in 58 seconds

More details
  • Looked at 48 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:243
  • Draft comment:
    Consider adding a check to ensure that the task is in an appropriate state (e.g., not completed or failed) before updating max_steps_per_run. This can prevent inconsistencies or unexpected behavior when tasks are updated in states that should not normally allow modifications.
  • Reason this comment was not posted:
    Confidence of 50% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_BKwATOKffVqPrUZn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5b5454c in 39 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:240
  • Draft comment:
    The PR description suggests changes related to updating the max_steps_per_run in the database, but the diff only shows schema changes. Please ensure that the necessary logic for updating the database is included in the PR.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_gcc2fqt0mqztHV0M


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 267335a into main Jul 19, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/record_max_steps_override branch July 19, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant