Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch academic/root to cmake #1173

Closed
wants to merge 2 commits into from
Closed

Switch academic/root to cmake #1173

wants to merge 2 commits into from

Conversation

arabusov
Copy link
Contributor

@arabusov arabusov commented Feb 8, 2022

This will allow us to compile ROOT v6.14 or higher. Current version
is v6.24-06. Many thanks to ponce for fixing some typos in this update.

@willysr
Copy link
Member

willysr commented Feb 9, 2022

Please don't remove the new template

@arabusov
Copy link
Contributor Author

arabusov commented Feb 9, 2022

@willysr could you please clarify what do you mean? Specifically, this template?

@willysr
Copy link
Member

willysr commented Feb 9, 2022

@arabusov
Copy link
Contributor Author

arabusov commented Feb 9, 2022

@willysr what I did was based on the previous version of the script (thus, I didn't remove any template), and what you are proposing is to rewrite the script completely from scratch based on the template. It will take some time.

@willysr
Copy link
Member

willysr commented Feb 9, 2022

No, you just need to make changes needed without having to remove the old code since it has been updated to comply with the new template

@arabusov
Copy link
Contributor Author

arabusov commented Feb 9, 2022

@willysr Ok, it seems in summer 2021 there were some updates I missed (fd9245f, 63daf9f), am I right?

@willysr
Copy link
Member

willysr commented Feb 9, 2022

well, a lot has happened in master branch :)
check it out here: https://git.slackbuilds.org/slackbuilds/
you can also search for specific package, like root
https://git.slackbuilds.org/slackbuilds/log/?qt=grep&q=root

@arabusov
Copy link
Contributor Author

arabusov commented Feb 9, 2022

@willysr using keyword "root" is not appropriate for searching in the repos, it's better to look at the file log itself: https://git.slackbuilds.org/slackbuilds/log/academic/root/root.SlackBuild

Here I see three commits from Heinz Wiesinger I didn't take into account. I'll fix my pull request accordingly.

This will allow us to compile ROOT v6.14 or higher. Current version
is v6.24-06. Many thanks to ponce for fixing some typos in this update.
The following commits were "restored":
63daf9f
7f26b99
@willysr
Copy link
Member

willysr commented Feb 10, 2022

merged

@willysr willysr closed this Feb 10, 2022
@arabusov arabusov deleted the hep branch February 10, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants