Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 8 programs (discord, grainy, inputstream.adaptive, kodi, libmediainfo, lirc, mediainfo, shairplay) #1690

Closed
wants to merge 12 commits into from

Conversation

bassmadrigal
Copy link
Contributor

Version bump 4 programs (inputstream.adaptive, discord, libmediainfo, mediainfo).
Remove optional dep from kodi and add instructions on how to upgrade python to fix kodi crashes (should be temporary until Pat next updates python3).
Optionally take over maintenance of kodi since Larry seems to be MIA. He has not responded to any emails and it seems others are having the same issue.
Finally, I updated my email in 3 programs (gbrainy, lirc, and shairplay), so I have a consistent email in all my packages.

There have been issues with kodi addons causing kodi to crash. It has been
determined that the problem is with python3 including the version that was
released with 15.0 and continues through 3.9.12 (the latest patch). This has
been fixed in 3.9.13, but that updated version hasn't made it to 15.0 yet. The
README.python contains instructions on how users can upgrade their python3
package until Pat releases a patch. The instructions will also be saved in the
program's /usr/doc directory.
Larry has not repsonded to several email messages and it seems no others have
been able to reach him as well.
@aclemons aclemons self-assigned this Jun 24, 2022
@bassmadrigal
Copy link
Contributor Author

Of course, after I submitted these yesterday, within a few hours I got notification updates for 3 newly released versions.

If you'd prefer, I can just delete this branch and resubmit everything without the unnecessary initial version bumps. Just let me know.

@aclemons
Copy link
Collaborator

That's ok, I can pull those in too.

@aclemons
Copy link
Collaborator

kodi is installing documentation in usr/share/doc/:

tree usr/share/doc/
usr/share/doc/
└── kodi
    ├── LICENSE.md
    ├── README.Linux.md
    ├── kodi-eventclients-dev
    │   └── examples
    │       ├── C#
    │       │   └── XBMCDemoClient1.cs
    │       ├── C++
    │       │   ├── example_button1.cpp
    │       │   ├── example_button2.cpp
    │       │   ├── example_log.cpp
    │       │   ├── example_mouse.cpp
    │       │   └── example_notification.cpp
    │       ├── java
    │       │   └── XBMCDemoClient1.java
    │       └── python
    │           ├── example_action.py
    │           ├── example_button1.py
    │           ├── example_button2.py
    │           ├── example_mouse.py
    │           ├── example_notification.py
    │           └── example_simple.py
    └── version.txt

7 directories, 16 files

@bassmadrigal
Copy link
Contributor Author

Thanks for the heads up. Nobody else caught it and I updated the SlackBuild before I was aware of sbolint.

I think adding -DCMAKE_INSTALL_DOCDIR=$PKG/usr/doc/$PRGNAM-$VERSION \ to the cmake lines will fix it, but I'm running through a build right now to check. We'll see how long it takes...

@aclemons
Copy link
Collaborator

Cool, thanks. I've also started a build here with that added.

@bassmadrigal
Copy link
Contributor Author

Build finished and now I have an unwanted /tmp directory. I think it needs to leave off the $PKG from that option. Trying again.

@bassmadrigal
Copy link
Contributor Author

I confirmed that removing the $PKG from that option fixed the installation. I've pushed a new commit to fix that.

Thanks for doing in-depth checks. I need to be better about that :)

@aclemons
Copy link
Collaborator

Thanks, staged to my branch now.

@aclemons aclemons closed this Jun 25, 2022
@aclemons aclemons removed their assignment Jun 25, 2022
@bassmadrigal bassmadrigal deleted the updates branch September 22, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants