development/jupyter-notebook: Fix errors associated with traitlets>=5.10 #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ sbolint - development/jupyter-notebook ✅ |
|
@sbo-bot: build development/jupyter-notebook |
buildpkg i586 development/jupyter-notebook |
sbopkglint i586 development/jupyter-notebook |
|
merged |
buildpkg x86_64 development/jupyter-notebook |
sbopkglint x86_64 development/jupyter-notebook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received the following error and warning (respectively) from running jupyter-notebook:
traitlets at version >=5.10 had brought about this issue.
My patch is drawn from the following discussion (by the way, the pull request below was already merged in jupyter-notebook 6.5.6):
jupyter/notebook#7051
I am not upgrading to jupyter-notebook 7, as it requires jupyterlab 4 (which itself I cannot upgrade due to requiring python-requests > 2.26).
I am also not upgrading to jupyter-notebook 6.5.6 - it invokes requirements of jupyter_client <8 and pyzmq <25 (these requirements were already added in jupyter-notebook 6.5.5). I will not ask Christoph to downgrade pyzmq.
Therefore, I think the only logical conclusion is to add this patch.