Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Resolution Impediments #28

Closed
rachelLagodka opened this issue Apr 6, 2012 · 24 comments
Closed

Call Resolution Impediments #28

rachelLagodka opened this issue Apr 6, 2012 · 24 comments

Comments

@rachelLagodka
Copy link
Member

The new button looks good, however, now all the recordings show up as having zero for their length, and indeed, when one clicks "play" there is nothing to which one can listen. An initial brief survey of members currently in the shop who have had contact with the application (Kieran, Tim, Max R) has yielded nothing so far in the way of a solution to the difficulty.

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

Inspect the element and see what the URL for the recording is. See if that URL points to an actual resource.

@rachelLagodka
Copy link
Member Author

also... there is no "submit" button at the bottom of the page, so checking the box won't do anything

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

@rachelLagodka
Copy link
Member Author

in static.urls.py link /media/public/audio/call_recordings/{{ phone_call_instance }} is not present.

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

What's the actual URL in the HTML (ie, if you inspect with firebug)? Is there a subdomain or port in the URL?

I don't think I know what you mean by phone_call_instance. Aren't the recording filenames hashed?

@rachelLagodka
Copy link
Member Author

there wasn't an actual url

@rachelLagodka
Copy link
Member Author

there was no audio in any of the urls-- what happened?

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

So the HTML tag had url="" ?

If so, check the template. I'm not sure. The twilio cases are not tested. I'm guessing there's some breakage.

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

Note that even if the twilio recordings aren't properly saved to the url of the PhoneCallRecording objects by the current view, we can correct this with a single manual REST call. http://www.twilio.com/docs/api/rest/call#list

@timgordon
Copy link
Member

in firebug it says...

url="/media/public/audio/call_recordings/audio(some_long_hash).mp3"

in urls.py there is no /media/public/audio...

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

(Is that a sensitive mp3 file?)

About the dispatcher: You are right - good looking out! :-)

However, you'll notice that the reason there's no mention of static service in django is because static media files are served separately by twisted in our deployment module:

https://github.com/SlashRoot/WHAT/blob/master/deployment/deploy_functions.py#L107

@timgordon
Copy link
Member

I made the numbers up...and how to I point them in the right direction?

@jMyles
Copy link
Member

jMyles commented Apr 6, 2012

Hmm?

@timgordon
Copy link
Member

hey I don't get one bit what it is I need to do here...I need more than hmm...that line you referenced looks like Russian to me...I need help to do this.

@jMyles
Copy link
Member

jMyles commented Apr 7, 2012

Haha, yeah I here you. The deployment stuff is tough man. Real tough. It's great code though - twisted is really amazing. I hope you come to understand it soon. I guess the first question is: If you actually SSH in and look at the production static file, does the mp3 in question exist?

@rachelLagodka
Copy link
Member Author

on the production server:

what/production/static/public/audio/call_recordings

does indeed exist and has contents

@jMyles
Copy link
Member

jMyles commented Apr 8, 2012

Well I know that. What I meant was: Does it have the actual MP3 in
question in it? (This might be an ops question and best left off
github, but for now let's keep pursuing it in case it represents a dev
bug)

@timgordon
Copy link
Member

there is indeed a call on the production server. in that folder. how do i point the play buttons to the proper location of the media?

@rachelLagodka
Copy link
Member Author

how do we save the Twilio recordings to the app
now that we know they need to be set ant tested as the tropo once was

@jMyles
Copy link
Member

jMyles commented Apr 15, 2012

There is a test for the Tropo case; make one for the Twilio case. Keep in mind that Twilio actually gives us a URL. You can http://www.twilio.com/docs/api/twiml/twilio_request#asynchronous

@jMyles
Copy link
Member

jMyles commented Apr 23, 2012

This ticket is still very much alive. It will be a very fun challenge to close it. Do you need any more help understanding it?

@ghost ghost assigned rachelLagodka Apr 23, 2012
@rachelLagodka
Copy link
Member Author

My difficulty is more procedural than heuristic. I'm in my attic.
The computer downstairs won't be shut off. Shld I unplug it?
------Original Message------
From: Justin Holmes
To: Rachel Lagodka
Subject: Re: [WHAT] Call Resolution Impediments (#28)
Sent: Apr 22, 2012 8:12 PM

This ticket is still very much alive. It will be a very fun challenge to close it. Do you need any more help understanding it?


Reply to this email directly or view it on GitHub:
#28 (comment)

Sent on the Sprint® Now Network from my BlackBerry®

@jMyles
Copy link
Member

jMyles commented May 4, 2012

I have lost track of this ticket. What exactly will constitute completion?

@jMyles
Copy link
Member

jMyles commented May 6, 2012

Ticket has become decayed and nondescript. Closing wontfix.

@jMyles jMyles closed this as completed May 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants