Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove activesupport constraints #467

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Remove activesupport constraints #467

merged 1 commit into from
Aug 11, 2020

Conversation

daneov
Copy link
Contributor

@daneov daneov commented Aug 11, 2020

These seem to have come from our downstream dependency, cocoapods, and
they have dropped the activesupport constraint in order to inherit it
from the core project.

Issue number: #465

These seem to have come from our downstream dependency, cocoapods, and
they have dropped the activesupport constraint in order to inherit it
from the core project.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.798% when pulling 330eec7 on daneov:remove_activesupport_constraints into 7cabe29 on SlatherOrg:master.

@ksuther ksuther merged commit 02ad622 into SlatherOrg:master Aug 11, 2020
@ksuther
Copy link
Contributor

ksuther commented Aug 11, 2020

Thanks for the PR!

@daneov
Copy link
Contributor Author

daneov commented Aug 11, 2020

You're welcome, @ksuther! Can I inquire on when I can expect this to land? :)

@ksuther
Copy link
Contributor

ksuther commented Aug 11, 2020

I'll look in to doing this over the weekend, time permitting.

@daneov
Copy link
Contributor Author

daneov commented Aug 11, 2020

Okay, thanks! Then I'll come by with adding a constraint by commit in my Gemfile until then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants