Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes should use Ore Dictionary ingotDarkSteel #2529

Closed
leagris opened this issue May 31, 2015 · 6 comments
Closed

Recipes should use Ore Dictionary ingotDarkSteel #2529

leagris opened this issue May 31, 2015 · 6 comments
Labels
bug Code Complete Wait for the next release...

Comments

@leagris
Copy link

leagris commented May 31, 2015

Crafting and Repair shall use Ore Dictionary names so it can use ingotDarkSteel from other mods.

With GregTech 5.08.18.jar maintained by @Blood-Asp, Dark Steel ingots are unified to gt:ingotDarkSteel, but these don't work for crafting Dark Steel Ball or repairing Dark Tools and Armour.

@MatthiasMann
Copy link
Contributor

I don't think GT's dark steel is comparable to EnderIO's?

@leagris
Copy link
Author

leagris commented May 31, 2015

It is not, but Gregtech 5.08.18 unificate DarkSteel Ingots from EnderIO into gt:ingotDarkSteell.
I just opened a related issue Blood-Asp/GT5-Unofficial#34 because until EIO can use Ore Dictionary names in recipes, it shall not default to unification.

@MatthiasMann
Copy link
Contributor

Well - why should we allow oredict use for EnderIO specific ingots - just because they have the same name?

@leagris
Copy link
Author

leagris commented May 31, 2015

Currently EnderIO register ingotDarkSteel to the OreDictionary but does not use the OreDictionary name within recipes.
To have other mods to play nicely, either:
If DarkSteel can be produced/referenced by other mods
Then: Use OreDictionary name in recipes
Else: Register a distinct namespace.

Anyway, it seems illogical to register an OreDictionary Name and not make use of it.

@Blood-Asp
Copy link

GT tries to integrade as many mods as possible into it's material/tool system to allow deeper cross mod interaction.
While Dark Steel is allready in for quite some time, i only activated it's active usage a few versions back on request.
The default unification taget not being EnderIO is my mistake and i will fix it soon. But it is right, that registering something in the oredic and not using oredic recipes makes no sense. If you do not allow materials of the same worth from other mods, then do not register it in the first place.

@tterrag1098 tterrag1098 added the bug label Jun 2, 2015
@tterrag1098
Copy link
Member

Fixed via d98be8d

@tterrag1098 tterrag1098 added the Code Complete Wait for the next release... label Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code Complete Wait for the next release...
Projects
None yet
Development

No branches or pull requests

5 participants