Use type-safe getTileEntity() in blocks #2835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can rework this to be standalone, as you don't like the generic handling one. |
HenryLoenwind
force-pushed
the
getEntity
branch
from
7f428d8
to
5b8abc5
Compare
tterrag1098
force-pushed
the
master
branch
2 times, most recently
from
f4f5089
to
a7c88ff
Compare
Closed
This was referenced Jan 24, 2016
|
For reference, another report: http://pastebin.com/nB0Lh1C0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #2834, which eliminates so many getTileEntity() calls. (Either pull only this or the other one first, in which case I'll rebase this one.)
Once SleepyTrousers/EnderCore#17 is in Ender IO's required EnderCore, I'll do the calls that have a IBlockAccess.