Fix character observer ending immediately when using immediate signal mode #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by some NPM-related items. Will be merged soon (hopefully today). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
When
workspace.SignalModeis set to Immediate mode, theCharacterAddedevent fires before the parent of the character is set. Thus, once a non-yielded observer function is executed, it thinks that the character has been destroyed, and calls the cleanup function returned from the observer. This does not occur when SignalMode is set to Deferred mode.To fix this, the observer function can be called within
task.deferinstead oftask.spawn. This ensures that the parent of the character has been assigned.