Skip to content

Commit

Permalink
BUG: Fix Qt lupdate warning about unconsumed metadata
Browse files Browse the repository at this point in the history 
Qt lupdate threw warnings about unconsumed metadata for lines that had translator's comments (that is exported to the language translation file to provide additonal context for translators) in the same line as the translatable text. For example:

    this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)");  //: file format name

The issue with this is that Qt expects translator comment to be in the previous line like this:

    //: File format name
    this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)");
  • Loading branch information
@lassoan
lassoan committed Sep 26, 2023
1 parent d3f49ed commit 23df3ce
Show file tree
Hide file tree
Showing 14 changed files with 126 additions and 64 deletions.
12 changes: 8 additions & 4 deletions Libs/MRML/Core/vtkMRMLColorTableStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,17 @@ int vtkMRMLColorTableStorageNode::WriteDataInternal(vtkMRMLNode *refNode)
//----------------------------------------------------------------------------

This comment has been minimized.

Sign in to view

Copy link
@jcfr

jcfr Sep 26, 2023 •
edited

Member

@lassoan If possible, let's try to avoid directly pushing to main and instead create a pull request.

If urgent and it has not been approved within 10-30mins ... the regular check can be bypassed.

Systematically creating a pull request is helpful to:

  • provide an opportunity for review
  • keep our openssf scorecard score up
  • rely on the auto-generation of release note (while we do not create such release, relying on the feature is helpful)

This comment has been minimized.

Sign in to view

Copy link
@lassoan

lassoan Sep 27, 2023

Author Contributor

This co. Mit was just moving comments from the end of the line to the line above.

I don't expect any review and it would just add noise to the release notes. But I don't know anything about the openssf scorecard. Can you give more information about it?

This comment has been minimized.

Sign in to view

Copy link
@jcfr

jcfr Sep 27, 2023

Member

The openssf scorecard is what we introduced a few weeks ago through:

By leveraging GitHub Action workflow1, it automatically performs the "measurement" to score the "health" of a project.

We initially had a score of 5.4, then after implementing a few changes we improved our score to 7.8:

Ideally, I would like to have our score fore "Branch Protection" being improved (at least Tier 2). See https://github.com/ossf/scorecard/blob/4edb07802fdad892fa8d10f8fd47666b6ccc27c9/docs/checks.md#branch-protection

Before enforcing the rule for administrator, I suggest we assess if we could keep our "Code Reviews" score up by having merge request and review whenever it made sense. When we started we were pushing a lot of changes directly without going through any review.

Footnotes

  1. https://github.com/Slicer/Slicer/actions/workflows/scorecard.yml ↩

This comment has been minimized.

Sign in to view

Copy link
@lassoan

lassoan Sep 27, 2023

Author Contributor

I'm OK with requiring pull requests for admins. We may need to add a label to make it easy to indicate that a review is urgent, and maybe another one to indicate that the review should be quick&trivial.
void vtkMRMLColorTableStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.txt)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.txt)");
}

//----------------------------------------------------------------------------
void vtkMRMLColorTableStorageNode::InitializeSupportedWriteFileTypes()
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.txt)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.ctbl)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLColorTableStorageNode", "MRML Color Table") + " (.txt)");
}
6 changes: 4 additions & 2 deletions Libs/MRML/Core/vtkMRMLLinearTransformSequenceStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,8 @@ int vtkMRMLLinearTransformSequenceStorageNode::WriteDataInternal(vtkMRMLNode *re
//----------------------------------------------------------------------------
void vtkMRMLLinearTransformSequenceStorageNode::InitializeSupportedReadFileTypes()
{
std::string fileType = vtkMRMLTr("vtkMRMLLinearTransformSequenceStorageNode", "Linear transform sequence"); //: file format name
//: File format name
std::string fileType = vtkMRMLTr("vtkMRMLLinearTransformSequenceStorageNode", "Linear transform sequence");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.seq.mhd)");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.seq.mha)");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.mha)");
Expand All @@ -609,7 +610,8 @@ void vtkMRMLLinearTransformSequenceStorageNode::InitializeSupportedReadFileTypes
//----------------------------------------------------------------------------
void vtkMRMLLinearTransformSequenceStorageNode::InitializeSupportedWriteFileTypes()
{
std::string fileType = vtkMRMLTr("vtkMRMLLinearTransformSequenceStorageNode", "Linear transform sequence"); //: file format name
//: File format name
std::string fileType = vtkMRMLTr("vtkMRMLLinearTransformSequenceStorageNode", "Linear transform sequence");
this->SupportedWriteFileTypes->InsertNextValue(fileType + " (.seq.mhd)");
this->SupportedWriteFileTypes->InsertNextValue(fileType + " (.seq.mha)");
this->SupportedWriteFileTypes->InsertNextValue(fileType + " (.mhd)");
Expand Down
58 changes: 38 additions & 20 deletions Libs/MRML/Core/vtkMRMLModelStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -743,17 +743,28 @@ int vtkMRMLModelStorageNode::WriteDataInternal(vtkMRMLNode *refNode)
//----------------------------------------------------------------------------
void vtkMRMLModelStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Polygon Mesh") + " (.vtk)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Polygon Mesh") + " (.vtp)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Unstructured Grid") + " (.vtk)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Unstructured Grid") + " (.vtu)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.g)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.byu)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "MetaIO Mesh") + " (.meta)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stereolithography Mesh") + " (.stl)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stanford Polygon Mesh") + " (.ply)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "AVS Unstructured Grid") + " (.ucd)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Wavefront Mesh") + " (.obj)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Polygon Mesh") + " (.vtk)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Polygon Mesh") + " (.vtp)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Unstructured Grid") + " (.vtk)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Unstructured Grid") + " (.vtu)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.g)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.byu)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "MetaIO Mesh") + " (.meta)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stereolithography Mesh") + " (.stl)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stanford Polygon Mesh") + " (.ply)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "AVS Unstructured Grid") + " (.ucd)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Wavefront Mesh") + " (.obj)");
}

//----------------------------------------------------------------------------
Expand All @@ -762,20 +773,27 @@ void vtkMRMLModelStorageNode::InitializeSupportedWriteFileTypes()
vtkMRMLModelNode* modelNode = this->GetAssociatedDataNode();
if (!modelNode || modelNode->GetMeshType() == vtkMRMLModelNode::PolyDataMeshType)
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Polygon Mesh") + " (.vtk)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Polygon Mesh") + " (.vtp)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Polygon Mesh") + " (.vtk)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Polygon Mesh") + " (.vtp)");
// Look at WriteData(), .g and .meta are not being written even though
// SupportedFileType() says they are supported
//this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.g)"); //: file format name
//this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.meta)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stereolithography Mesh") + " (.stl)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stanford Polygon Mesh") + " (.ply)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Wavefront Mesh") + " (.obj)"); //: file format name
//this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.g)");
//this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Movie.BYU Mesh") + " (.meta)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stereolithography Mesh") + " (.stl)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Stanford Polygon Mesh") + " (.ply)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "Wavefront Mesh") + " (.obj)");
}
if (!modelNode || modelNode->GetMeshType() == vtkMRMLModelNode::UnstructuredGridMeshType)
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Unstructured Grid") + " (.vtk)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Unstructured Grid") + " (.vtu)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK Unstructured Grid") + " (.vtk)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLModelStorageNode", "VTK XML Unstructured Grid") + " (.vtu)");
}
}

Expand Down
12 changes: 8 additions & 4 deletions Libs/MRML/Core/vtkMRMLProceduralColorStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,17 @@ int vtkMRMLProceduralColorStorageNode::WriteDataInternal(vtkMRMLNode *refNode)
//----------------------------------------------------------------------------
void vtkMRMLProceduralColorStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.cxml)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.txt)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.cxml)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.txt)");
}

//----------------------------------------------------------------------------
void vtkMRMLProceduralColorStorageNode::InitializeSupportedWriteFileTypes()
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.cxml)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.txt)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.cxml)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLProceduralColorStorageNode", "MRML Color Function") + " (.txt)");
}
6 changes: 4 additions & 2 deletions Libs/MRML/Core/vtkMRMLSegmentationStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ void vtkMRMLSegmentationStorageNode::Copy(vtkMRMLNode *anode)
//----------------------------------------------------------------------------
void vtkMRMLSegmentationStorageNode::InitializeSupportedReadFileTypes()
{
std::string fileType = vtkMRMLTr("vtkMRMLSegmentationStorageNode", "Segmentation"); //: file format name
//: File format name
std::string fileType = vtkMRMLTr("vtkMRMLSegmentationStorageNode", "Segmentation");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.seg.nrrd)");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.seg.nhdr)");
this->SupportedReadFileTypes->InsertNextValue(fileType + " (.seg.vtm)");
Expand Down Expand Up @@ -173,7 +174,8 @@ void vtkMRMLSegmentationStorageNode::InitializeSupportedWriteFileTypes()
masterIsPolyData = true;
}
}
std::string fileType = vtkMRMLTr("vtkMRMLSegmentationStorageNode", "Segmentation"); //: file format name
//: File format name
std::string fileType = vtkMRMLTr("vtkMRMLSegmentationStorageNode", "Segmentation");
if (masterIsImage)
{
this->SupportedWriteFileTypes->InsertNextValue(fileType + " (.seg.nrrd)");
Expand Down
12 changes: 8 additions & 4 deletions Libs/MRML/Core/vtkMRMLSequenceStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,19 @@ int vtkMRMLSequenceStorageNode::WriteDataInternal(vtkMRMLNode *refNode)
//----------------------------------------------------------------------------
void vtkMRMLSequenceStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.seq.mrb)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.mrb)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.seq.mrb)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.mrb)");
}

//----------------------------------------------------------------------------
void vtkMRMLSequenceStorageNode::InitializeSupportedWriteFileTypes()
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.seq.mrb)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.mrb)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.seq.mrb)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLSequenceStorageNode", "MRML Sequence Bundle") + " (.mrb)");
}

//----------------------------------------------------------------------------
Expand Down
6 changes: 4 additions & 2 deletions Libs/MRML/Core/vtkMRMLTableSQLiteStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ int vtkMRMLTableSQLiteStorageNode::DropTable(char *tableName, vtkSQLiteDatabase*
//----------------------------------------------------------------------------
void vtkMRMLTableSQLiteStorageNode::InitializeSupportedReadFileTypes()
{
std::string dbStr = vtkMRMLTr("vtkMRMLTableSQLiteStorageNode", "SQLight database"); //: file format name
//: File format name
std::string dbStr = vtkMRMLTr("vtkMRMLTableSQLiteStorageNode", "SQLight database");
this->SupportedReadFileTypes->InsertNextValue(dbStr + " (.db)");
this->SupportedReadFileTypes->InsertNextValue(dbStr + " (.db3)");
this->SupportedReadFileTypes->InsertNextValue(dbStr + " (.sqlite)");
Expand All @@ -313,7 +314,8 @@ void vtkMRMLTableSQLiteStorageNode::InitializeSupportedReadFileTypes()
//----------------------------------------------------------------------------
void vtkMRMLTableSQLiteStorageNode::InitializeSupportedWriteFileTypes()
{
std::string dbStr = vtkMRMLTr("vtkMRMLTableSQLiteStorageNode", "SQLight database"); //: file format name
//: File format name
std::string dbStr = vtkMRMLTr("vtkMRMLTableSQLiteStorageNode", "SQLight database");
this->SupportedWriteFileTypes->InsertNextValue(dbStr + " (.db)");
this->SupportedWriteFileTypes->InsertNextValue(dbStr + " (.db3)");
this->SupportedWriteFileTypes->InsertNextValue(dbStr + " (.sqlite)");
Expand Down
18 changes: 12 additions & 6 deletions Libs/MRML/Core/vtkMRMLTableStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -225,17 +225,23 @@ int vtkMRMLTableStorageNode::WriteDataInternal(vtkMRMLNode *refNode)
//----------------------------------------------------------------------------
void vtkMRMLTableStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.tsv)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Comma-separated values") + " (.csv)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.txt)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.tsv)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Comma-separated values") + " (.csv)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.txt)");
}

//----------------------------------------------------------------------------
void vtkMRMLTableStorageNode::InitializeSupportedWriteFileTypes()
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.tsv)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Comma-separated values") + " (.csv)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.txt)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.tsv)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Comma-separated values") + " (.csv)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTableStorageNode", "Tab-separated values") + " (.txt)");
}

//----------------------------------------------------------------------------
Expand Down
18 changes: 12 additions & 6 deletions Libs/MRML/Core/vtkMRMLTextStorageNode.cxx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,23 @@ int vtkMRMLTextStorageNode::WriteDataInternal(vtkMRMLNode * refNode)
//----------------------------------------------------------------------------
void vtkMRMLTextStorageNode::InitializeSupportedReadFileTypes()
{
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "Text file") + " (.txt)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "XML document") + " (.xml)"); //: file format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "JSON document") + " (.json)"); //: file format name
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "Text file") + " (.txt)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "XML document") + " (.xml)");
//: File format name
this->SupportedReadFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "JSON document") + " (.json)");
}

//----------------------------------------------------------------------------
void vtkMRMLTextStorageNode::InitializeSupportedWriteFileTypes()
{
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "Text file") + " (.txt)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "XML document") + " (.xml)"); //: file format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "JSON document") + " (.json)"); //: file format name
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "Text file") + " (.txt)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "XML document") + " (.xml)");
//: File format name
this->SupportedWriteFileTypes->InsertNextValue(vtkMRMLTr("vtkMRMLTextStorageNode", "JSON document") + " (.json)");
}

//----------------------------------------------------------------------------
Expand Down

0 comments on commit 23df3ce

Please sign in to comment.