Skip to content

Commit

Permalink
ENH: Update SimpleFilters module
Browse files Browse the repository at this point in the history
SimpleFilters update includes these two commits:

Revision: 98c60ecea0e5c46c4d1b57bd772b466c053453f2
Author: Andras Lasso <lasso@queensu.ca>
Date: 2024-04-17 5:46:32 PM
Message:
Make image transfer between Slicer and SimpleITK more robust

Use higher-level API to push/pull images from Slicer. The lower-level API that was used (based on `GetSlicerITKReadWriteAddress`) only works with the SimpleITK version that has MRMLIDImageIO.

Revision: 05496b391d7f70ec9dda4d62b61f03e34c08c15e
Author: Andras Lasso <lasso@queensu.ca>
Date: 2023-10-26 1:09:45 PM
Message:
BUG: Fix output node selection and error reporting

- Allow using output nodes that have special characters in the name (for example, if output node contained square brackets [] in the name then SimpleFilters module threw an error)
- Do not overwrite input volume by default (user needs to explicitly select the output)
- Use a label instead of a checkbox to indicate that the selected output node is a labelmap. Users were confused by why the checkbox is there and why it was disabled.
- Make all errors visible to users (for example, when running ResampleImageFilter on MRBrainTumor1 sample data set with default parameters, the execution silently failed)
- Print stack trace to application log to help troubleshooting for developers
  • Loading branch information
lassoan committed Apr 19, 2024
1 parent 03ff788 commit 29f6b91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion SuperBuild.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ list_conditional_append(Slicer_BUILD_MultiVolumeImporter Slicer_REMOTE_DEPENDENC

Slicer_Remote_Add(SimpleFilters
GIT_REPOSITORY ${EP_GIT_PROTOCOL}://github.com/SimpleITK/SlicerSimpleFilters.git
GIT_TAG 92e8db0030f6f9d9ea99dd5d8d1425b6b2189a68
GIT_TAG e82fc598bc010505e994b7ce22d953a9899a175c
OPTION_NAME Slicer_BUILD_SimpleFilters
OPTION_DEPENDS "Slicer_BUILD_QTSCRIPTEDMODULES;Slicer_USE_SimpleITK"
LABELS REMOTE_MODULE
Expand Down

0 comments on commit 29f6b91

Please sign in to comment.