Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extension category when uploading extension a new package manager #5010

Closed
jcfr opened this issue Jun 24, 2020 · 0 comments · Fixed by #5017
Closed

Include extension category when uploading extension a new package manager #5010

jcfr opened this issue Jun 24, 2020 · 0 comments · Fixed by #5017
Assignees
Labels
Type: Bug Something isn't working correctly
Milestone

Comments

@jcfr
Copy link
Member

jcfr commented Jun 24, 2020

The category metadata is missing from the package server.

Note: This instance is currently internally hosted at Kitware

For example, it is missing from last night extension associated with revision 29173:

http://192.168.113.208:8080/api/v1/app/5aa3da37f3eb080001497b3d/extension?app_revision=29173&os=macosx&arch=amd64&sort=created&sortdir=-1

[
    {
        "_id": "5ef328794db7a400019d60f4",
        "baseParentId": "5a8c800cd7a3fb0001b37cdd",
        "baseParentType": "collection",
        "created": "2020-06-24T10:18:33.564000+00:00",
        "creatorId": "5a8c7f58d7a3fb0001b37cd9",
        "description": "",
        "folderId": "5ef3113f4db7a400019d5f9a",
        "lowerName": "29173_slicermorph_macosx_amd64_41bae1a",
        "meta": {
            "app_id": "5aa3da37f3eb080001497b3d",
            "app_revision": "29173",
            "arch": "amd64",
            "baseName": "SlicerMorph",
            "description": "",
            "os": "macosx",
            "repository_type": "git",
            "repository_url": "https://github.com/SlicerMorph/SlicerMorph.git",
            "revision": "41bae1a"
        },
        "name": "29173_SlicerMorph_macosx_amd64_41bae1a",
        "size": 701055,
        "updated": "2020-06-24T10:18:33.567000+00:00"
    },
    [...]

Steps to reproduce

Inspect metadata associated with uploaded extensions:

image

Expected behavior

category should be listed

Environment

NA

Proposed solution

Update invocation of to specify --category (see slicer_package_manager_client/cli.py and girder/slicer_package_manager#75)

execute_process(COMMAND
${CMAKE_COMMAND} -E env
LC_ALL=en_US.UTF-8
LANG=en_US.UTF-8
${SLICER_EXTENSION_MANAGER_CLIENT_EXECUTABLE}
--api-url ${SLICER_EXTENSION_MANAGER_URL}/api/v1
--api-key ${SLICER_EXTENSION_MANAGER_API_KEY}
extension upload Slicer ${p}
--os ${EXTENSION_OPERATING_SYSTEM}
--arch ${EXTENSION_ARCHITECTURE}
--name ${EXTENSION_NAME}
--repo_type ${EXTENSION_WC_TYPE}
--repo_url ${EXTENSION_WC_URL}
--revision ${EXTENSION_WC_REVISION}
--app_revision ${Slicer_REVISION}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working correctly
Development

Successfully merging a pull request may close this issue.

1 participant