Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanishing color table icons on volumes module #5834

Closed
fbordignon opened this issue Sep 2, 2021 · 1 comment
Closed

Vanishing color table icons on volumes module #5834

fbordignon opened this issue Sep 2, 2021 · 1 comment
Assignees
@lassoan
Labels
Type: Bug Something isn't working correctly
Milestone
Slicer 4.13

Comments

@fbordignon
Copy link
Contributor

When the user selects a scalar volume, switches to a labelmap and go back to the scalar volume, the icons of the lookup tables disappear:

image

Steps to reproduce

  1. Load Mr. Head
  2. Create a segmentation
  3. Convert the segmentation to a labelmap
  4. Go to volumes module
  5. Select Mr. Head scalar volume
  6. Select the labelmap
  7. Selec Mr. Head again
  8. Icons disappear

Expected behavior

Keep the colormap icons

Environment

  • Slicer version: Slicer-4.13.0-2021-08-31
  • Operating system: Windows 10
@fbordignon fbordignon added the Type: Bug Something isn't working correctly label Sep 2, 2021
@lassoan lassoan closed this as completed in d499def Sep 5, 2021
@lassoan lassoan self-assigned this Sep 5, 2021
@lassoan lassoan added this to the Slicer 4.13.0 milestone Sep 5, 2021
@lassoan
Copy link
Contributor

lassoan commented Sep 5, 2021

Thanks for reporting. The problem is fixed now.

@lassoan lassoan mentioned this issue Sep 5, 2021
Closed
fbordignon pushed a commit to fbordignon/Slicer that referenced this issue Nov 16, 2021
@lassoan @fbordignon
BUG: Fix disappearing icons in color node selector
91e689e 
When the scene model was rebuilt from scratch (for example, due to batch update or closing the scene), the color gradient icons disappeared from the color node selector qMRMLColorTableComboBox.

The problem was that the icons were lost because the model items were recreated, but the nodes were still the same (singleton nodes are not deleted when the scene is closed), so the icons were not set again.

fixes Slicer#5834
fixes Slicer#4721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
Type: Bug Something isn't working correctly
Milestone
Slicer 4.13
Development

No branches or pull requests
2 participants
@lassoan @fbordignon