Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Update build-system to support forcing extension revision #6378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

COMP: Update build-system to support forcing extension revision #6378

wants to merge 2 commits into from

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented May 14, 2022

No description provided.

@jcfr jcfr linked an issue May 14, 2022 that may be closed by this pull request
Update extension build-system to support forcing use of specific revision #6377
Open
@jcfr jcfr requested a review from lassoan May 14, 2022 02:21
@jcfr jcfr force-pushed the support-forcing-extension-revision branch from 666e215 to 8dbd3da Compare May 14, 2022 16:45
lassoan
lassoan reviewed May 15, 2022
View reviewed changes
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've tested this a bit and found a few little issues. Now that we are working on this I think it would be nice to address them.

CMake/SlicerExtensionCPack.cmake Outdated Show resolved Hide resolved
CMake/SlicerExtensionCPack.cmake Outdated Show resolved Hide resolved
CMake/SlicerExtensionCPack.cmake Outdated Show resolved Hide resolved
CMake/SlicerExtensionCPack.cmake Outdated Show resolved Hide resolved
CMake/SlicerExtensionCPack.cmake Outdated Show resolved Hide resolved
@lassoan lassoan added this to the Slicer 5.3 milestone Oct 17, 2022
@lassoan lassoan modified the milestones: Slicer 5.3, Backlog Jul 9, 2023
@jcfr jcfr force-pushed the support-forcing-extension-revision branch from 8dbd3da to 74beb4c Compare January 27, 2024 20:07
jcfr and others added 2 commits January 27, 2024 15:09
@jcfr @lassoan
COMP: Update build-system to support forcing extension revision
e796237 
Co-authored-by: Andras Lasso <lasso@queensu.ca>
@jcfr @lassoan
ENH: Improve author warning accuracy in SlicerMacroExtractRepositoryInfo
d98abb4 
Co-authored-by: Andras Lasso <lasso@queensu.ca>
@jcfr jcfr force-pushed the support-forcing-extension-revision branch from 74beb4c to d98abb4 Compare January 27, 2024 20:10
@jcfr
Copy link
Member Author

jcfr commented Jan 27, 2024

Thanks for testing and for providing detailed suggestion.

I also checked that rerunning cmake in a already configured build tree kept the forced revision.

@jcfr jcfr enabled auto-merge (rebase) January 27, 2024 20:13
@jcfr jcfr requested a review from lassoan January 27, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan Awaiting requested review from lassoan

At least 1 approving review is required to merge this pull request.

Assignees

@jcfr jcfr

Labels
Domain: build-system
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Update extension build-system to support forcing use of specific revision
2 participants
@jcfr @lassoan