Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build-system removing unused CMake macros & variables related to i18n #6894

Open
8 tasks
jcfr opened this issue Mar 15, 2023 · 0 comments
Open
8 tasks
Labels
Domain: build-system Domain: i18n Internationalization (language translation) Type: Enhancement Improvement to functionality
Milestone

Comments

@jcfr
Copy link
Member

jcfr commented Mar 15, 2023

Is your feature request related to a problem? Please describe.

Following the introduction of the Translation update helper script through #6674, the processing of the sources can be done directly without having to rely on CMake.

Describe the solution you'd like

To streamline the overall maintenance of the build-system, the proposed updates are:

  • Remove SlicerMacroTranslation.cmake and update module using it:
    • SlicerMacroBuildModuleWidgets.cmake
    • SlicerMacroBuildApplication.cmake
    • SlicerMacroBuildBaseQtLibrary.cmake
    • SlicerMacroBuildLoadableModule.cmake
  • Remove global property Slicer_QM_OUTPUT_DIRS
  • Remove support for QM_OUTPUT_FILES
  • Confirm that the use of Slicer_QM_DIR and Slicer_QM_OUTPUT_DIRS in vtkSlicerConfigure.h.in and SlicerDirectories.cmake is still relevant.

Describe alternatives you've considered

Move forward with improving CMake support initiated in these pull-requests:

Additional context

NA

@jcfr jcfr added the Type: Enhancement Improvement to functionality label Mar 15, 2023
@jcfr jcfr added this to the Slicer 5.3 milestone Mar 15, 2023
@jcfr jcfr modified the milestones: Slicer 5.3, Backlog Jun 20, 2023
@jcfr jcfr added Domain: i18n Internationalization (language translation) Domain: build-system labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: build-system Domain: i18n Internationalization (language translation) Type: Enhancement Improvement to functionality
Development

No branches or pull requests

1 participant