Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold Ranger Issue: Not Working When Saving and Restoring Scene with Segment Editor open #7576

Closed
MujassimJamal opened this issue Feb 8, 2024 · 0 comments · Fixed by #7609

Comments

@MujassimJamal
Copy link
Contributor

MujassimJamal commented Feb 8, 2024

Summary

I downloaded sample data (e.g., MRHead SampleData) and, without further action, saved the scene as a bundle with the segment editor module open. When I loaded the bundle again, I created one segment and attempted to change the threshold value. However, I noticed a bug: the threshold ranger slicer and spinner are not changeable; they are in a disabled state. I have only tested this issue with the threshold effect, and I am not certain if it occurs with other effects as well.

Steps to reproduce

1. Navigate to File → Download Sample Data → MRHead.
2. Open the Segment Editor module.
3. Press Ctrl+S to save the scene as an .mrb bundle with the segment editor open.
4. Go to File → Close Scene.
5. Go to File → Add Data → Choose file(s) and load the previously saved .mrb file.
6. In the Segment Editor, add one or more segments.
7. Navigate to the Threshold effect and attempt to change the threshold range.
8. Notice that it won't work => the Slicer should allow modification of the threshold value.

Video reference: https://drive.google.com/file/d/1tyr15I-fqalwKyngdpUph0i1hq9-lcDI/view?usp=sharing
Screen capture:

image

Environment

  • Slicer version: Slicer-5.6.1-2023-12-12
  • Operating system: Windows 11

References

@MujassimJamal MujassimJamal changed the title Threshold Ranger Issue: Not Working When Saving and Restoring Scene with Open Segment Editor Threshold Ranger Issue: Not Working When Saving and Restoring Scene with Segment Editor open Feb 8, 2024
lassoan added a commit to lassoan/Slicer that referenced this issue Feb 29, 2024
NRRD file cannot be created without voxel data, so an 1x1x1 array was used as image data.
However, when the empty segmentation was loaded then this single-voxel geometry was treated as a valid geometry.
Fixed by detecting this special case of a single voxel in the segmentation, and considering the geometry invalid in this case.

fixes Slicer#7576
lassoan added a commit to lassoan/Slicer that referenced this issue Feb 29, 2024
NRRD file cannot be created without voxel data, so an 1x1x1 array was used as image data.
However, when the empty segmentation was loaded then this single-voxel geometry was treated as a valid geometry.
Fixed by detecting this special case of a single voxel in the segmentation, and considering the geometry invalid in this case.

fixes Slicer#7576
lassoan added a commit that referenced this issue Feb 29, 2024
NRRD file cannot be created without voxel data, so an 1x1x1 array was used as image data.
However, when the empty segmentation was loaded then this single-voxel geometry was treated as a valid geometry.
Fixed by detecting this special case of a single voxel in the segmentation, and considering the geometry invalid in this case.

fixes #7576

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant