Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: OSX -isysroot not being used in external non-cmake projects #1167

Closed

Conversation

Projects
None yet
2 participants
@blowekamp
Copy link

commented Jul 1, 2019

CMake 3 replaced OSX specific CMAKE_CXX_HAS_ISYSROOT with the
generalized CMAKE_CXX_SYSROOT_FLAG. The patch restores setting
-isysroot for non-CMake based external projects.

BUG: OSX -isysroot not being used in external non-cmake projects
CMake 3 replaced OSX specific CMAKE_CXX_HAS_ISYSROOT with the
generalized CMAKE_CXX_SYSROOT_FLAG. The patch restores setting
-isysroot for non-CMake based external projects.
@jcfr

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Thanks for the fix.

For reference, see Kitware/CMake@a0a0877

@jcfr

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Closing. Integrated in r28356

@jcfr jcfr closed this Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.