Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update operating system versions for recent Slicer stable #5252

Merged
merged 1 commit into from Oct 15, 2020

Conversation

jamesobutler
Copy link
Contributor

The recent slicer stable is referring to Slicer-4.11.20200930

@lassoan
Copy link
Contributor

lassoan commented Oct 15, 2020

Thank you, good catch!

Readthedocs is already versioned (I've just enabled building of stable tag):
https://slicer.readthedocs.io/en/stable/
https://slicer.readthedocs.io/en/latest/

Since the doc always refers to the "current" version (that users can choose in the readthedocs version selector), I think we can remove reference to stable/preview version and only write about what is applicable to the current version (remove the table and just list OS requirements for the current master version).

Could you update the pull request accordingly? Thank you!

Documentation is versioned so there is not a need for both Stable and Preview information.
@jamesobutler
Copy link
Contributor Author

I've pushed an update to remove the Stable/Preview specification.

I guess this means I'm unable to update the current stable documentation to fix the operating system version requirements because it has already been released and there is no maintenance branch for building the latest stable documentation.

@lassoan
Copy link
Contributor

lassoan commented Oct 15, 2020

Good point. Although we don't plan to release not patches for 4.11, we can still create a branch from the 20200930 version and update the documentation. I've created a v4.11 for this purpose and enabled documentation generation for it: https://slicer.readthedocs.io/en/v4.11/ (and disabled documentation generation for the stable tag to keep things more clear).

You can send a pull request to the v4.11 branch. Maybe the exact same commit would work.

Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants