New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Pluggable Markups #5349
ENH: Pluggable Markups #5349
Commits on Apr 12, 2021
-
This includes the following change: - Moving all icons to `Markups/Resources/Icons` - Renaming `MarkupsMouse...` by `MarkupsFiducialMouse...` to keep naming consistency - Adding a new `MarkupsGeneric...` set of icons
Rafael Palomar committedApr 12, 2021 Configuration menu - View commit details
-
Copy full SHA for c4c3640 - Browse repository at this point
Copy the full SHA c4c3640View commit details
Commits on Apr 13, 2021
-
ENH: Add pluggable markups architecture
This allows the creation and registration of markups in modules other than the Markups module Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Co-authored-by: Andras Lasso <lasso@queensu.ca> Co-authored-by: Kyle Sunderland <sunderlandkyl@gmail.com> Co-authored-by: Steve Pieper <pieper@isomics.com> Co-authored-by: Csaba Pinter <pinter.csaba@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9710dd3 - Browse repository at this point
Copy the full SHA 9710dd3View commit details -
STYLE: Using const Qstring& on qSlicerSimpleMarkupsWidget
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for af06796 - Browse repository at this point
Copy the full SHA af06796View commit details -
ENH: Bring markups naming consistency (Slicer#5196)
This extends the markups labels naming by adding a short-name version of the labels. This short-name version of the labeling is established as default. Disambiguation of open and close curves is achieved by setting the label to 'OC' and 'CC' respectively. The reason for this change is to bring consistency in the naming of markups. Before this commit, placing markups from the selection node toolbar will use short naming, while placing markups from the Markups module GUI would use long names. This closes Slicer#5196.
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 5ee1d82 - Browse repository at this point
Copy the full SHA 5ee1d82View commit details -
STYLE: Rename qMRMLMarkupsROIWidget
This renames qMRMLMarkupsROIWidget to qSlicerMarkupsROIWidget in order to keep naming consistency across markups widgets.
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 962aa6d - Browse repository at this point
Copy the full SHA 962aa6dView commit details -
STYLE: Fix indenting in various markups files
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 08d511b - Browse repository at this point
Copy the full SHA 08d511bView commit details -
ENH: Add unit tests for pluggable markups logic
This adds a new test file to validate the functionality of pluggable makups on `vtkMRMLMarkupsLogic`
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 006275c - Browse repository at this point
Copy the full SHA 006275cView commit details -
ENH: Add unit tests for markups factory
This adds unit testing for `qSlicerMarkupsAdditionalOptionsWidgetsFactory`
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 6b3d3c6 - Browse repository at this point
Copy the full SHA 6b3d3c6View commit details -
ENH: Add Pluggable Markups testing loadable module
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for e308771 - Browse repository at this point
Copy the full SHA e308771View commit details -
ENH: Add Pluggable Markups python self test
Rafael Palomar committedApr 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 237d11b - Browse repository at this point
Copy the full SHA 237d11bView commit details