Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Pluggable Markups #5349

Merged
merged 10 commits into from Apr 13, 2021
Merged

Commits on Apr 12, 2021

  1. ENH: Reorganize Markups icons

    This includes the following change:
    
    - Moving all icons to `Markups/Resources/Icons`
    - Renaming `MarkupsMouse...` by `MarkupsFiducialMouse...` to keep naming consistency
    - Adding a new `MarkupsGeneric...` set of icons
    Rafael Palomar committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c4c3640 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. ENH: Add pluggable markups architecture

    This allows the creation and registration of markups in modules other
    than the Markups module
    
    Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    Co-authored-by: Andras Lasso <lasso@queensu.ca>
    Co-authored-by: Kyle Sunderland <sunderlandkyl@gmail.com>
    Co-authored-by: Steve Pieper <pieper@isomics.com>
    Co-authored-by: Csaba Pinter <pinter.csaba@gmail.com>
    6 people committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    9710dd3 View commit details
    Browse the repository at this point in the history
  2. STYLE: Using const Qstring& on qSlicerSimpleMarkupsWidget

    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    af06796 View commit details
    Browse the repository at this point in the history
  3. ENH: Bring markups naming consistency (Slicer#5196)

    This extends the markups labels naming by adding a short-name version of
    the labels. This short-name version of the labeling is established as
    default. Disambiguation of open and close curves is achieved by setting
    the label to 'OC' and 'CC' respectively.
    
    The reason for this change is to bring consistency in the naming of
    markups. Before this commit, placing markups from the selection node
    toolbar will use short naming, while placing markups from the Markups
    module GUI would use long names.
    
    This closes Slicer#5196.
    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5ee1d82 View commit details
    Browse the repository at this point in the history
  4. STYLE: Rename qMRMLMarkupsROIWidget

    This renames qMRMLMarkupsROIWidget to qSlicerMarkupsROIWidget in order
    to keep naming consistency across markups widgets.
    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    962aa6d View commit details
    Browse the repository at this point in the history
  5. STYLE: Fix indenting in various markups files

    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    08d511b View commit details
    Browse the repository at this point in the history
  6. ENH: Add unit tests for pluggable markups logic

    This adds a new test file to validate the functionality of pluggable
    makups on `vtkMRMLMarkupsLogic`
    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    006275c View commit details
    Browse the repository at this point in the history
  7. ENH: Add unit tests for markups factory

    This adds unit testing for `qSlicerMarkupsAdditionalOptionsWidgetsFactory`
    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    6b3d3c6 View commit details
    Browse the repository at this point in the history
  8. ENH: Add Pluggable Markups testing loadable module

    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    e308771 View commit details
    Browse the repository at this point in the history
  9. ENH: Add Pluggable Markups python self test

    Rafael Palomar committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    237d11b View commit details
    Browse the repository at this point in the history